Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

PERF #95

Open
4 tasks
stefanpenner opened this issue Mar 9, 2017 · 1 comment
Open
4 tasks

PERF #95

stefanpenner opened this issue Mar 9, 2017 · 1 comment

Comments

@stefanpenner
Copy link
Collaborator

stefanpenner commented Mar 9, 2017

  • pre-sort payload from server, so first load needs no sorting
  • store updated times as seconds since epoc (number) that way comparison / parsing is much simpler/faster.
  • make sortProperties flat https://github.com/gcollazo/ember-cli-addon-search/blob/master/app/components/em-list.js#L51 no foo.bar only foo
  • skip Ember.compare when sorting over a very large diverse set this can be unfortunately slow due to how flexible it is. Rather we should try to only sort via number compare or localecompare
@stefanpenner
Copy link
Collaborator Author

array.sort() sorting overhead today is pretty hefty:

screen shot 2017-03-09 at 12 16 02 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant