Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetElementsIT should test "unrelated" query with edges #3132

Open
t92549 opened this issue Dec 8, 2023 · 0 comments
Open

GetElementsIT should test "unrelated" query with edges #3132

t92549 opened this issue Dec 8, 2023 · 0 comments
Labels
enhancement Improvement to existing functionality/feature
Milestone

Comments

@t92549
Copy link
Contributor

t92549 commented Dec 8, 2023

Compare the current GetElementsIT:

shouldGetElementsBySeed(includeEntities, false, directedType, inOutType);

and GetElementsIT from Gaffer 1.23.0:
shouldGetElementsBySeed(includeEntities, includeEdges, directedType, inOutType);

Disabling of this test with edges was done because the SeedMatching behaviour changed. This test should be improved and re-enabled.

I suspect the alternative operation isn't good enough and needs to filter seeds and store the results from the first GetElements in a SetExport:

if (createChain && includeEntities && includeEdges) {

@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Dec 8, 2023
@t92549 t92549 added this to the v2.2.0 milestone Dec 8, 2023
@t92549 t92549 self-assigned this Dec 8, 2023
@t92549 t92549 removed their assignment Jan 5, 2024
@GCHQDeveloper314 GCHQDeveloper314 modified the milestones: v2.2.0, Backlog Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Development

No branches or pull requests

2 participants