Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federated store tests need to be reorganised and refactored #3079

Open
t92549 opened this issue Nov 10, 2023 · 0 comments
Open

Federated store tests need to be reorganised and refactored #3079

t92549 opened this issue Nov 10, 2023 · 0 comments
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module tech-debt Relates to Technical Debt
Milestone
Medium Term Backlog

Comments

@t92549
Copy link
Contributor

t92549 commented Nov 10, 2023

Currently, the federated store module ignores the Gaffer IT framework that the other stores use for integration tests and has over 30 tests in one directory. Most of these are incorrectly named Test when they should be IT and should implement StandaloneIT like the other stores do. This would allow for more shared logic and less repetition between the tests, e.g. setting up a graph in each test.
@t92549 t92549 added enhancement Improvement to existing functionality/feature tech-debt Relates to Technical Debt federated-store Specific to/touches the federated-store module labels Nov 10, 2023
@GCHQDeveloper314 GCHQDeveloper314 added this to the Medium Term Backlog milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module tech-debt Relates to Technical Debt
Projects
None yet
Milestone
Medium Term Backlog
Development

No branches or pull requests
2 participants
@t92549 @GCHQDeveloper314