Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental Refresh Policy not applied despite "Full" refresh #33

Open
Lvanlaar26 opened this issue Jun 28, 2024 · 3 comments
Open

Incremental Refresh Policy not applied despite "Full" refresh #33

Lvanlaar26 opened this issue Jun 28, 2024 · 3 comments

Comments

@Lvanlaar26
Copy link

My understanding is that a "Full" refresh would give the same results as an On Demand refresh of the semantic model via the service. But I'm getting different results when it comes to Incremental Refresh.

When triggering the full refresh via VS Code, partitions are not created or dropped as expected.

This is following a VS Code Full refresh on 6/26, for a model that has an IR policy enabled for Monthly partitions:

image

I was surprised to not see a new partition created for 2024Q206.

Two days later (with no other changes) I triggered an On Demand refresh via the service and got the expected result:

image

I'm on v2.1.1 of the extension and I've experienced this with a few different models. Let me know if I have a misunderstanding of the expected functionality.

Thanks!

@gbrueckl
Copy link
Owner

gbrueckl commented Jul 1, 2024

there was another issue #27 where we explicitly set the applyRefreshPolicy to false
guess I have to rework this and make it more granular
e.g. if you select a partition -> applyRefreshPolicy = false
if you select a table/whole dataset -> applyRefreshPolicy = true

will implement it in the next release

@gbrueckl
Copy link
Owner

gbrueckl commented Jul 1, 2024

ok, was a quick fix I think - just released v2.1.2 where this should be fixed now (as described above)

could you please check @Lvanlaar26 and report back here if the issue still exists

@Lvanlaar26
Copy link
Author

Worked great - Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants