-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRSciColl - make suggestions searchable by country #555
Comments
We don't have a column for the country in the DB so the filtering should be done after retrieving the results. We could implement it in the api but it could also be done directly in the UI, there wouldn't be too much difference. |
thanks @marcos-lg |
Both are good. I mean, for both cases it has to be implemented at the api level and not at the query label, so we can do any or both of them. Whatever is more useful. |
@marcos-lg on the landing page of pending suggestions I can see the country attribute at https://registry.gbif.org/suggestions/institutions?status=PENDING. I suppose the information is suppose to be there when an user submit it. Did you mean that country information isn't stored in the DB? Otherwise for implementing this feature I think it'll be indeed useful if country is available as a filter option. |
Yeah, the country is there but it is "calculated" when retrieving the suggestions. But we can still add a country filter. |
I'm going to transfer this issue to the registry-console since storing the country in the DB is troublesome because if the country of the entity changes we'd have to update the suggestions to keep it consistent. And doing the filter with the calculated value in the api is also troublesome because of the paging. Therefore, I think it's simpler to do the filtering directly in the UI. |
@marcos-lg I would have to pull all suggestions/results into the browser to filter them. Currently around 900 of them. I do not think that is a good solution either. And it will only become worse as the list of suggestions grow over time. |
Ok, it's the same problem as in the backend. The only solution is to store the field in the DB but we'd have to keep it synced with the collection/institution, i.e.: if the country changes in the collection/institution we need to change it in the suggestion too, so not sure if it's worth the effort. |
As we get more GRSciColl mediators, it would be helpful if they could search suggestions by country.
Sometimes, a mediator can miss notifications or there might be several mediators for one country so you need to check which suggestions were applied.
It would be helpful if they could just go here: https://registry.gbif.org/suggestions/institutions?status=PENDING and select the country they want to check.
Would that be possible @marcos-lg, what do you think?
The text was updated successfully, but these errors were encountered: