Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt UI to the new GRSciColl data model #563

Closed
6 tasks done
marcos-lg opened this issue Apr 10, 2024 · 9 comments
Closed
6 tasks done

Adapt UI to the new GRSciColl data model #563

marcos-lg opened this issue Apr 10, 2024 · 9 comments
Assignees

Comments

@marcos-lg
Copy link
Contributor

marcos-lg commented Apr 10, 2024

The following changes have to be adapted in the UI since some of them are breaking changes:

This is not a priority but I also added the Latimer Core endpoints:

These changes are only available in DEV for the moment and will be deployed to the other environments together with the UI.

@ManonGros
Copy link
Collaborator

Concerning Latimer Core, when it comes to the UI, for now I think we could do one of the followings:

  1. Have a button (on the GRScicoll entry pages and/or on the search result page) which is the API call to access data formatted as Latimer Core. And have one in the registry UI for uploading data as LtC
  2. Just have a link to the API that specifies that you can access and upload GRSciColl data formatted as Latimer core.

Maybe for now (and given that it isn't urgent), I vote for number 2.

@ManonGros
Copy link
Collaborator

See also the issue about addresses: gbif/registry#546

@ManonGros
Copy link
Collaborator

Thanks @MortenHofft!

For the drop down selection of vocabulary, could there be some visual cue to show that the concepts are nested? Right now, it is the same as the enum drop down list.

Ideally, when I manage to add the definitions to the concepts as well, I would like to show that there are definitions. Maybe some (i) and the definition shown when hovering? (I am not sure what is best here). This part isn't as important as showing that the concepts aren't flat.

@MortenHofft
Copy link
Member

MortenHofft commented May 15, 2024

@ManonGros Is it a feature that is preventing us from going to production? Or is what we have in uat better than prod?

In other words can we take it to production in its current state and then you can leave a distinct issue for improving the dropdown? Or is it a critical bug that prevents us from going live?

@ManonGros
Copy link
Collaborator

We can't take it to production because now the values have almost no context.

For example, this is what we have currently on prod where "archeological" is repeated for each sub value.
Screenshot 2024-05-15 at 12 28 21
This is what we have on dev:
Screenshot 2024-05-15 at 12 27 58
There is "archeological" as its own concept way down below and the context for each sub concept is gone. It looks more confusing than before.

Ideally, we would have something in the drop down that shows the nested aspect of the concepts:

Archeological
|-> C14
|-> humain remains
|-> ...

If not, then we should at least have something equivalent to what we have now where the parent concept is displayed for each sub-concept. Something like this:

  • Archeological
  • Archeological | C14
  • Archeological | humain remains
  • Archeological | ...

@ManonGros
Copy link
Collaborator

@MortenHofft For the GRSciColl (hosted) portal, we also need to add the temporal coverage field on collection pages and display the images when provided (the later I couldn't test on dev because there is a bug preventing me to save changes).
Should I log it as a separate issue?

@MortenHofft
Copy link
Member

Personally I prefer individual issues over mega issues yes. especially when it concerns another project. Hosted portals and registry-console are independent projects/code bases.

@ManonGros
Copy link
Collaborator

Thanks @MortenHofft ! I logged two issues there: gbif/hosted-portals#287 gbif/hosted-portals#286

@ManonGros
Copy link
Collaborator

Thanks Morten! That will work for prod

MortenHofft added a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants