Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate resource logo URL is an URL starting with http or https #2584

Open
mike-podolskiy90 opened this issue Nov 7, 2024 · 0 comments
Open
Assignees
Labels
Milestone

Comments

@mike-podolskiy90
Copy link
Contributor

mike-podolskiy90 commented Nov 7, 2024

Issues were discovered in this IPT https://ipt.jbrj.gov.br/jabot

IPT accepts images to be embed like data:[<mediatype>][;base64],<data> which is not accepted by the registry. Registry expects logos to be proper URLs starting with http or https and it prevents resources from registration.

https://github.com/gbif/gbif-api/blob/dev/src/main/java/org/gbif/api/util/URIValidator.java#L55

So we have to align the IPT with the registry and require the same.

@mike-podolskiy90 mike-podolskiy90 self-assigned this Nov 7, 2024
@mike-podolskiy90 mike-podolskiy90 added this to the 3.2 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant