Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions and ideas #32

Open
MortenHofft opened this issue Apr 6, 2022 · 1 comment
Open

Suggestions and ideas #32

MortenHofft opened this issue Apr 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@MortenHofft
Copy link
Member

MortenHofft commented Apr 6, 2022

I have looked at the website and it looks great. Congratulations. I normally try to go through websites just before they launch to act as the first user. So here comes an issue with ideas and suggestions. Feel free to ignore them all and close this issue.

  • occurrences are currently shown under the url /data - I suggest you rename it to /occurrence/search or something more informative than /data I'm aware that was the default when you received the template from me :)
  • I see you use graphql as dataset search backend. You have a limit of 2147483647. That isn't the real limit. It is more like around 1000 or so (I cannot remember the exact threshold the API has). It might not matter currently, but if the network grows you should consider proper paging. The API allows for it ( it is sitting on top of APIv1 documented here)
  • I just tried a dataset page.
    • The GBIF API had a response time of 4.5 seconds. That is fairly long without a loader - perhaps you should add one. Normally the API is much faster, but a loader is probably a good idea either way.
    • As I told @siwelisabeth elsewhere I think it works very nice with you little chips with a star that tells you what information is provided on the dataset. Perhaps it could be used as navigation as well when on an individual dataset? So clicking it would take me to the section in case? Just a thought - my first hunch was to click it.
    • readability: I think the rule of thumb for line lenghts is around 70 characters per line. You have around 180. It might be worth trying shorter lines?
    • I find that my mouse is often "caught" by the map when scrolling to read. You could consider disabling until the user has started interaction? But perhaps that is also annoying, just a thought.
  • It looks like you are using the default search filters and columns for occurrence search. Which is fine, but be aware that you can change it https://hp-theme.gbif-staging.org/data-exploration-config
  • The technical blog isn't included in the menu. Just in case you missed it and wanted it there.

That is all the feedback I could come up with - that wasn't much. I hope you are happy with it. Let me know if I can help with anything.

@siwelisabeth
Copy link
Collaborator

Thank you @MortenHofft for the feedback and suggestions for improvement, we really appreciate it. Some of this we have thought of and are going to improve in near future (such as pagination, loader and dataset filtering) and other things are good ideas that we havent thought of and will take with us in the further developement.

We also want to thank you for excellent support in this developement process. :-) :-)

@frafra frafra added the enhancement New feature or request label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants