Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display featured images when provided for GRSciColl institutions and collection #287

Open
ManonGros opened this issue May 15, 2024 · 11 comments

Comments

@ManonGros
Copy link
Collaborator

This relates to this issue: gbif/registry#552 and this one: gbif/registry#516. Editors will now have the possibility to provide a featured image for their collection and/or institution. Those should be displayed on the portal when provided.

@ManonGros
Copy link
Collaborator Author

Following our slack conversation, we would have:

@MortenHofft
Copy link
Member

4:1 is a difficult ratio to work with I would think. Isn't something like 5:2 more realistic for users. Especially if it is also to work well in 3:2?

Below is a 4:1 image
Screenshot 2024-05-24 at 08 21 52

@MortenHofft
Copy link
Member

There is also a difference between pages.
3:1 https://grscicoll.hp.gbif-uat.org/collection/a647fdb4-b8f9-43cc-9c8a-447ca038b393 have no sidebar.
3:2 https://grscicoll.hp.gbif-uat.org/institution/ff9e52d6-7dc2-42d9-a5d4-3352ff31461f have a sidebar.
Had the images been reversed, then the 3:2 image would have been enormous. Especially when looking at a smaller narrow laptop

@ManonGros ManonGros changed the title Display featured mages when provided for GRSciColl institutions and collection Display featured images when provided for GRSciColl institutions and collection May 24, 2024
@ManonGros
Copy link
Collaborator Author

Thanks @MortenHofft ! Would it make sense to have 3:2 for everything? What do you think @javiesgm ?

@MortenHofft
Copy link
Member

MortenHofft commented May 24, 2024

I would say 5:2 or so. Would it make sense to upload various ratios to try it out in practice? on pages with and without sidebar? and keep in mind that most users are on a laptop.

It is my impression that the ratio on gbif.org has been difficult enough to find good images for. And that has a ratio of 2.8 so roughly 3:1
https://www.gbif.org/data-use/eicNfKNgbTHiIveqMpjA1/are-rare-species-more-common-than-common-species

Anyway: let me know what to do. I just felt like saying that 1:4 sounds difficult for the users

@javiesgm
Copy link

Yes, I agree with the challenge that 4:1 proposes. The relation between 3:2 and 3:1 may be better. How about having 1:1, 2:1, 3:1, and 3:2. Too many options?
ratios

@MortenHofft
Copy link
Member

I was hoping the users only had to give us one image. And then we cropped it (or contained it) to a fixed ratio. That we always used. Perhaps with the exception of listing results where it might be useful to use something more square. But that might be what you are saying as well.

My fear is that we end up with something that look like MySpace anno 2006 by giving choice. So fixing what is possible to one ratio for all would help. Perhaps even not showing the image if the resolution is too low. Discarding animated gifs as well :)

@ManonGros
Copy link
Collaborator Author

It makes sense to use (and ask) only for one ratio. How about we drop the idea of displaying the images on the "collection" tab of institutions? That makes things complicated.

That way we can choose one ratio that looks good on institution and collection pages without having to think too much about the rest. What do you think?

@javiesgm
Copy link

javiesgm commented May 24, 2024 via email

@MortenHofft
Copy link
Member

3:2 on pages without sidebar (no occurrences)
https://grscicoll.hp.gbif-uat.org/institution/e772c6d6-bbc8-40c8-92e9-b74407e1f5bb

3:2 with sidebar.
https://grscicoll.hp.gbif-uat.org/institution/ff9e52d6-7dc2-42d9-a5d4-3352ff31461f

3:1 no sidebar
https://grscicoll.hp.gbif-uat.org/collection/a647fdb4-b8f9-43cc-9c8a-447ca038b393

3:1 on pages with sidebar
https://grscicoll.hp.gbif-uat.org/collection/43783fa4-48f0-4098-aaea-50d950e168e0


I do not think that the current layout works well with 3:2 if there is no sidebar. The image is enormous in those case. But we could rethink the way we display the images.
The registry UI now shows a preview in 1:1 and 3:1 https://registry.gbif-uat.org/collection/a647fdb4-b8f9-43cc-9c8a-447ca038b393
If users upload images that work in both ratios, then we have plenty of wiggle room to try out different layouts once we have some images. We might also learn that users find that it is too difficult to find images that work under those constraints.

@MortenHofft
Copy link
Member

We could do like meetup and have the image in the header.
Screenshot 2024-05-27 at 10 02 52

For consistency they create a blob placeholder like above when there is no image uploaded by the user.
Personally I like that the layout is consistent (there is ALWAYS an image), but then we need generic placeholder images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants