-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 handling broken #260
Comments
The Beaty Museum has a 404.html page, which is what the sites are configured to use: hp-beaty-biodiversity-museum/404.html Cartagena has a directory: hp-cartagena-botanical-garden/404/index.html It's a global configuration shared by all the sites, so ideally we use the same thing everywhere. |
I cannot force them to be the same as the editors can change it as well, but I can add an explicit url to the 404's and hope they do not get overwritten. Currently they differ because of the _config. In theory we could also normalize that with an additional file that defined how permalinks should use. Without or without .html |
Could we have a fallback to the fallback? It is a thing that is easy to change but hard to notice when doing changes in Jekyll |
@MattBlissett It seems something has changed in the way we handle 404s
They do not show the dedicated 404 page anymore
prod: https://data.dissco-uk.org/tester
staging: https://cartagena-botanical-garden.hp.gbif-staging.org/tester
but some also work: https://beaty-biodiversity-museum.hp.gbif-staging.org/tester
The text was updated successfully, but these errors were encountered: