Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 handling broken #260

Open
MortenHofft opened this issue Aug 29, 2023 · 3 comments
Open

404 handling broken #260

MortenHofft opened this issue Aug 29, 2023 · 3 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@MortenHofft
Copy link
Member

@MattBlissett It seems something has changed in the way we handle 404s
They do not show the dedicated 404 page anymore

prod: https://data.dissco-uk.org/tester
staging: https://cartagena-botanical-garden.hp.gbif-staging.org/tester

but some also work: https://beaty-biodiversity-museum.hp.gbif-staging.org/tester

@MortenHofft MortenHofft added the Type: Bug Something isn't working label Aug 29, 2023
@MortenHofft MortenHofft changed the title 404 handling 404 handling broken Aug 29, 2023
@MattBlissett
Copy link
Member

The Beaty Museum has a 404.html page, which is what the sites are configured to use: hp-beaty-biodiversity-museum/404.html

Cartagena has a directory: hp-cartagena-botanical-garden/404/index.html

It's a global configuration shared by all the sites, so ideally we use the same thing everywhere.

@MortenHofft
Copy link
Member Author

MortenHofft commented Aug 30, 2023

I cannot force them to be the same as the editors can change it as well, but I can add an explicit url to the 404's and hope they do not get overwritten. Currently they differ because of the _config. In theory we could also normalize that with an additional file that defined how permalinks should use. Without or without .html
Let me start by simply making them all the same to begin with

@MortenHofft
Copy link
Member Author

Could we have a fallback to the fallback? It is a thing that is easy to change but hard to notice when doing changes in Jekyll

MortenHofft added a commit to gbif/hp-beaty-biodiversity-museum that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-gb30 that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-canadensys that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-land that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-uzbekistan that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-legume that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-antarctic that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-arctic-university-museum-norway that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-dissco-flanders that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-sanbi that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-cartagena-botanical-garden that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-uk-collections that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-herbarium-germany that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-mapping-asia-plants that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-gelechiidae that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-galerucines that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-tettris that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-eabcn that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-bison that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-us-collections that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-nhm-rotterdam that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-biodiversidata that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-template that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-campanulaceae that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-latin-america-caribbean that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-demo-tecala that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-living-norway that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-sprep that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-gb29 that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-new-zealand that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-benin that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-sibuy that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-asean that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-ngbif that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-demo-fungi that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-kenbif that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-vtatlasoflife that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-taylor-herbarium that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-nhc-template that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-demo-nhc-dark that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-vertnet-plus that referenced this issue Oct 6, 2023
MortenHofft added a commit to gbif/hp-canadian-biodiversity that referenced this issue Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants