Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry Python object lacks API's for Heightmaps #1439

Closed
Erumeldor opened this issue Jun 18, 2024 · 3 comments · Fixed by #1440
Closed

Geometry Python object lacks API's for Heightmaps #1439

Erumeldor opened this issue Jun 18, 2024 · 3 comments · Fixed by #1440
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Erumeldor
Copy link

Starting from SDFormat 1.9, SDFormat XML has a tag, but the SDFormat Python API Geometry class does not seem to support it.

The C++ functions HeightmapShape and SetHeightmapShape are not linked.

There is even a small comment in the source file.
https://github.com/gazebosim/sdformat/blob/sdf14/python/src/sdf/pyGeometry.cc
@Erumeldor Erumeldor added the enhancement New feature or request label Jun 18, 2024
@azeey
Copy link
Collaborator

azeey commented Jun 18, 2024

Thanks for reporting this @Erumeldor. Would you be interested in adding those missing functions?

@azeey azeey added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 18, 2024
@azeey azeey moved this from Inbox to To do in Core development Jun 18, 2024
@ahcorde ahcorde mentioned this issue Jun 19, 2024
Merged
9 tasks
@ahcorde
Copy link
Collaborator

ahcorde commented Jun 19, 2024

PR #1440

@scpeters
Copy link
Member

for reference, the C++ bindings were added in #388

@github-project-automation github-project-automation bot moved this from To do to Done in Core development Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added SetHeightMap and Heighmap to Geometry Python binding gazebosim/sdformat
4 participants
@azeey @ahcorde @scpeters @Erumeldor