Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros_gz_bridge: GZ -> ROS /clock publisher #581

Closed
asherikov opened this issue Jul 23, 2024 · 3 comments
Closed

ros_gz_bridge: GZ -> ROS /clock publisher #581

asherikov opened this issue Jul 23, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@asherikov
Copy link

Hello, I've been investigating poor performance of the /clock topic and noticed a couple of issues:

  1. Publisher does not use ClockQoS by default (https://github.com/ros2/rclcpp/blob/rolling/rclcpp/include/rclcpp/qos.hpp#L364), which would be beneficial.
  2. Heavy sensor topics (cameras, lidars) interfere with the clock publisher by introducing delays since they share the same single threaded spinner.

The issue can be addressed with a dedicated bridge instance with qos and node name overrides, but given the importance of the clock topic it makes sense to create a dedicated node to simplify usage of the bridge.

@asherikov asherikov added the enhancement New feature or request label Jul 23, 2024
@azeey
Copy link
Contributor

azeey commented Jul 29, 2024

It is possible to have a separate bridge (I.e, a separate process) for the clock node with its own QOS setting, but having better defaults would be great. @asherikov are you interested in working on this?

@azeey azeey added the help wanted Extra attention is needed label Jul 29, 2024
@azeey azeey moved this from Inbox to To do in Core development Jul 29, 2024
@asherikov
Copy link
Author

Hi, it looks like adding a dedicated node requires the least amount of work, otherwise the bridge would require significant refactoring: custom settings for a specific topic, multithreaded spinning, etc. I have solved my problems with a dedicated instance of the bridge, so I am currently not interested in working on a better solution.

@azeey
Copy link
Contributor

azeey commented Jul 30, 2024

Thanks for the response! I'll close this issue then. I have opened another issue to better document QoS settings.

@azeey azeey closed this as completed Jul 30, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Core development Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants