Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mappings for gz.msgs.AirSpeedSensor and gz.msgs.Altimeter #382

Open
srmainwaring opened this issue Apr 19, 2023 · 6 comments
Open

Add mappings for gz.msgs.AirSpeedSensor and gz.msgs.Altimeter #382

srmainwaring opened this issue Apr 19, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@srmainwaring
Copy link

Desired behavior

Provide mappings for sensor data:

  • gz.msgs.AirSpeedSensor
  • gz.msgs.Altimeter

Alternatives considered

  • NA.

Implementation suggestion

The main issue is which ROS message type to target as these messages do not have a corresponding message in sensor_msgs.

Additional context

Would be happy to submit a PR for this feature request once a suitable ROS message type is agree upon.

@srmainwaring srmainwaring added the enhancement New feature or request label Apr 19, 2023
@azeey azeey self-assigned this May 1, 2023
@adityapande-1995 adityapande-1995 self-assigned this May 1, 2023
@azeey
Copy link
Contributor

azeey commented May 1, 2023

We've been creating our own ROS messages when a compatible message type is not available in the ROS ecosystem (see https://github.com/gazebosim/ros_gz/tree/ros2/ros_gz_interfaces). Can we do the same here?

@ahcorde
Copy link
Collaborator

ahcorde commented May 8, 2023

Feel free to add me as a reviewer @srmainwaring

@adityapande-1995
Copy link
Contributor

adityapande-1995 commented Jun 13, 2023

Adding Altimeter bridging here : #413.
Note, addin AirSpeedSensor also requires adding SensorNoise msg.

@adityapande-1995
Copy link
Contributor

SensorNoise msg work in progress : #417

@azeey azeey moved this to In progress in Core development Jul 24, 2023
@wittenator
Copy link
Contributor

Is there anything missing for the AirSpeedSensor? I would also be very interested in having this data in ROS

@wittenator
Copy link
Contributor

Just for the sake of documentation: It seems that the Air Speed sensor msgs only exists in gz_msgs 9+. Since the current stable version of ros_gz is using Fortress and therefore gz_msgs version 7, there is no message to bridge atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

5 participants