Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling light visualization in ign-gazebo5 #638

Closed
ahcorde opened this issue Feb 18, 2021 · 3 comments · Fixed by #1343
Closed

Toggling light visualization in ign-gazebo5 #638

ahcorde opened this issue Feb 18, 2021 · 3 comments · Fixed by #1343
Labels
close the gap Features from Gazebo-classic 🏢 edifice Ignition Edifice enhancement New feature or request good first issue Good for newcomers GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience rendering Involves Ignition Rendering

Comments

@ahcorde
Copy link
Contributor

ahcorde commented Feb 18, 2021

Desired behavior

When the Light editor is forward ported to ign-gazebo5 we should allow to toggle light visualization in ign-gazebo5

Additional context

Refer to these PRs #482 and gazebosim/gz-rendering#202 for more context
@ahcorde ahcorde added enhancement New feature or request good first issue Good for newcomers close the gap Features from Gazebo-classic 🏢 edifice Ignition Edifice labels Feb 18, 2021
@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering labels Feb 18, 2021
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Dec 20, 2021
This was referenced Feb 16, 2022
Merged
Merged
@ahcorde ahcorde linked a pull request Feb 25, 2022 that will close this issue
Allow to turn on/off lights #1343
Merged
7 tasks
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 25, 2022

Related PRs

@chapulina
Copy link
Contributor

Thanks for the on/off feature, @ahcorde !

For the visualization itself, I think it would be interesting to have a <visualize> SDF parameter like we have for sensors, then toggle that from the GUI.

@ahcorde ahcorde mentioned this issue Mar 11, 2022
Merged
8 tasks
@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 11, 2022

Allow to enable/disable light visuals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
close the gap Features from Gazebo-classic 🏢 edifice Ignition Edifice enhancement New feature or request good first issue Good for newcomers GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience rendering Involves Ignition Rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to turn on/off lights gazebosim/gz-sim
2 participants
@ahcorde @chapulina