You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gz-cmake3 installs many cmake files and adds the containing folder to the CMAKE_MODULE_PATH so that packages that find_package(gz-cmake3) will be able to use those cmake files.
We would like to install cmake files from other packages as well (such as gz-physics) and append the path of the installed folder to the CMAKE_MODULE_PATH. We could expose this functionality as a flag or parameter to the gz_create_core_library and gz_add_component cmake functions, since that is where the cmake config templates are instantiated.
Unconditionally add a specific path for each package to the CMAKE_MODULE_PATH so it doesn't have to be configured. This may pollute the CMAKE_MODULE_PATH, so it would be cleaner to opt in to the functionality.
Implementation suggestion
Additional context
The text was updated successfully, but these errors were encountered:
I think rather than appending to the CMAKE_MODULE_PATH, I may take the approach that ament does and allow the user to generate a gz-package<VER>-extras.cmake file that can provide hooks into other installed cmake files.
Desired behavior
gz-cmake3
installs manycmake
files and adds the containing folder to theCMAKE_MODULE_PATH
so that packages thatfind_package(gz-cmake3)
will be able to use those cmake files.We would like to install cmake files from other packages as well (such as gz-physics) and append the path of the installed folder to the
CMAKE_MODULE_PATH
. We could expose this functionality as a flag or parameter to thegz_create_core_library
andgz_add_component
cmake functions, since that is where the cmake config templates are instantiated._gz_create_cmake_package function
in GzPackaging.cmake is called by gz_create_core_library and gz_add_component inGzUtils.cmake
.Alternatives considered
Unconditionally add a specific path for each package to the
CMAKE_MODULE_PATH
so it doesn't have to be configured. This may pollute theCMAKE_MODULE_PATH
, so it would be cleaner to opt in to the functionality.Implementation suggestion
Additional context
The text was updated successfully, but these errors were encountered: