Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded actions? #2

Open
AnshulMalik opened this issue Apr 5, 2018 · 4 comments
Open

Hard coded actions? #2

AnshulMalik opened this issue Apr 5, 2018 · 4 comments
Labels
question Further information is requested

Comments

@AnshulMalik
Copy link

Right now, there are a few actions supported and those too are hard coded.

It'd be really awesome if the application can support actions based on text without manually mapping text to the actions. Manually specifying all the actions looks really really bad.

@AnshulMalik AnshulMalik added the question Further information is requested label Apr 5, 2018
@AnshulMalik
Copy link
Author

I came across this nice little service
https://wit.ai/getting-started

@kayforkaran
Copy link
Contributor

These are hardcoded so that the code is easier to understand for freshers. This might be a first hand experience for a lot of them, so in my opinion it would be better if we just keep things to the basic level.
While this suggestion is good, I believe it would be better if we keep its scope to optional and to be taught only if time permits. If the functionality is to be added here, we should add it in a new branch that is for the extension of the current code after the students are able to reach the current level of the codebase.

@ankitxjoshi
Copy link
Member

The whole purpose was to make things pluggable. Remove hard coded actions. Remove hard coded strings. Keep a seperate constants.py for holding strings. Make an abstract class which other plugins will use.

@AnshulMalik
Copy link
Author

Any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants