You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a bot-command is mentioned in a comment and the same bot command is quoted in the same comment, the action may not run that bot command because of how we parse the comments.
One use case for this might be someone replying to someone else:
" You need to use @zulipbot claim to claim an issue. @zulipbot claim"
One solution for this might be to use matchAll() instead of match() in parseComment, so that we can get the starting index of the command and then we can check if the matched quoted command is found near to the command for which it is being checked for.
One more issue that can arise in the current implementation of bot-commands is that is someone write a bot-command in a comment, along with some other stuff and then someone else quote replies the complete comment, so the bot-commands will also run for that other person.
One solution for this might be to modify regex to check if the current line starts with the > symbol. This can be done by starting the regex with ^ and checking if there is a > symbol after that and if there is not, allowing any number of any characters before the actual bot command starts.
If a bot-command is mentioned in a comment and the same bot command is quoted in the same comment, the action may not run that bot command because of how we parse the comments.
One use case for this might be someone replying to someone else:
" You need to use
@zulipbot claim
to claim an issue.@zulipbot claim"
One solution for this might be to use
matchAll()
instead ofmatch()
inparseComment
, so that we can get the starting index of the command and then we can check if the matched quoted command is found near to the command for which it is being checked for.See logs for https://github.com/garg3133/git-github-demo/runs/2651318874?check_suite_focus=true
The text was updated successfully, but these errors were encountered: