From 9fcc95421e2a8e40f3b023ed16a71cbcfaddf14d Mon Sep 17 00:00:00 2001 From: Alexander Richards Date: Mon, 16 Oct 2023 09:31:45 +0100 Subject: [PATCH 1/3] Update ci_push_testing.yml --- .github/workflows/ci_push_testing.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci_push_testing.yml b/.github/workflows/ci_push_testing.yml index c88a1a80fb..7bb440a8a9 100644 --- a/.github/workflows/ci_push_testing.yml +++ b/.github/workflows/ci_push_testing.yml @@ -7,7 +7,10 @@ on: jobs: approve: name: Approval + if: startsWith(github.ref, 'ganga-devs/**') != true runs-on: ubuntu-latest + environment: + name: Integrate Pull Request steps: - name: Approve run: echo For security reasons, all pull requests need to be approved first before running any automated CI. @@ -17,8 +20,6 @@ jobs: name: Linting runs-on: ubuntu-latest needs: [approve] - environment: - name: Integrate Pull Request continue-on-error: true outputs: files_to_lint: ${{ steps.flake8.outputs.files_to_lint }} From ee7496dc5a7067e7af6a116d8bf2f536a73e85c3 Mon Sep 17 00:00:00 2001 From: Alexander Richards Date: Mon, 16 Oct 2023 09:54:37 +0100 Subject: [PATCH 2/3] Update ci_push_testing.yml --- .github/workflows/ci_push_testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_push_testing.yml b/.github/workflows/ci_push_testing.yml index 7bb440a8a9..af9043972a 100644 --- a/.github/workflows/ci_push_testing.yml +++ b/.github/workflows/ci_push_testing.yml @@ -7,7 +7,7 @@ on: jobs: approve: name: Approval - if: startsWith(github.ref, 'ganga-devs/**') != true + if: github.repository != 'ganga-devs/gangs' runs-on: ubuntu-latest environment: name: Integrate Pull Request From d73fb70108b391f7fd53c2bfaa89e14303d0e83a Mon Sep 17 00:00:00 2001 From: Alexander Richards Date: Mon, 16 Oct 2023 10:01:51 +0100 Subject: [PATCH 3/3] Update ci_push_testing.yml --- .github/workflows/ci_push_testing.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci_push_testing.yml b/.github/workflows/ci_push_testing.yml index af9043972a..ae1cfd53bd 100644 --- a/.github/workflows/ci_push_testing.yml +++ b/.github/workflows/ci_push_testing.yml @@ -5,21 +5,21 @@ on: branches: [ develop ] jobs: - approve: - name: Approval - if: github.repository != 'ganga-devs/gangs' - runs-on: ubuntu-latest - environment: - name: Integrate Pull Request - steps: - - name: Approve - run: echo For security reasons, all pull requests need to be approved first before running any automated CI. + #approve: + # name: Approval + # if: github.repository != 'ganga-devs/gangs' + # runs-on: ubuntu-latest + # environment: + # name: Integrate Pull Request + # steps: + # - name: Approve + # run: echo For security reasons, all pull requests need to be approved first before running any automated CI. lint: name: Linting runs-on: ubuntu-latest - needs: [approve] + #needs: [approve] continue-on-error: true outputs: files_to_lint: ${{ steps.flake8.outputs.files_to_lint }}