-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview about MAGIC articles #157
Comments
@pdeiml - Thanks for doing the overview and starting the MAGIC data entry! I'm not familiar with their papers, and have no time to look, so I won't be able to help you if you have any question which papers are relevant or not. Personally I'm only interested in Galactic sources, and would give priority to sources (if any left) that don't have a single measurement in gamma-cat yet: https://github.com/cdeil/gamma-cat-status/blob/master/cat_table_printout.csv |
Ok, but as soon as I start to add any data problems may arise and then I will write you my questions in the corresponding PR :-) But don't worry, this will work in some way at some point. |
Just to note here what we discussed on Skype. IMO this huge task / TODO table in this issue is not maintainable. I did the same when I added HESS data, then I moved it to lists in the Suggest to instead transfer the info from the table above into For hand-written notes like "we should have all MAGIC papers up to 2016 according to this list" or something like this, we should use some docs page. Suggest to do this work of getting set up in a good way first (and closing this issue) before spending time doing more MAGIC data entry. |
@pdeiml - Just as an example I've added a few I'm not sure if we should try to be complete in the list of MAGIC publications. There will always be many "nice to have" papers like conference proceedings and papers with upper limits, so I think the attempt to add I'll stop with gamma-cat again now. @pdeiml - Please transfer the list above into |
@cdeil I will be going through the input folders and check whether the reference already have a folder/ info.yaml/ dummy yaml-file. |
Please make one PR adding all |
I need help with these two articles: https://arxiv.org/abs/0706.1505 https://arxiv.org/abs/astro-ph/0602231 |
@pdeiml - Please add what you can, and leave the few you're unsure about somewhere in a reminder issue. Leave both of those out for now. Then we can look at / discuss them individually, or if needed talk to someone from MAGIC about. These are upper limit papers on sources that weren't detected. So for Cygnus X-1 we'd have to add a "detected" flag to our basic source info schema first. I.e. best to postpone this to a separate issue (or just not add it for now, focus on the meat of available measurements and add those first; that's what Gernot is doing for VERITAS). |
Ok, I make here an overview about the articles I am not sure about and then we can discuss later on and close this issue as soon as EVERY article was being looked at. :-) |
Overwiew about publications that need further discussion: 2006ApJ...641L...9A |
Hi, this is Michele Doro (currently publication manager of MAGIC). I can help you with MAGIC papers (or find somebody). Note you can cross-check MAGIC Publication information with the NASA ADS archive: ui.adsabs.harvard.edu/#/public-libraries/7QbEh28fSY-6jzxej_D7mw |
Hi again, I hope somebody is reading this. I discussed yesterday with people from the SSDC (ASI science data center). They told me they will contact you. They started a similar catalog some time ago: http://www.asdc.asi.it/tgevcat/. To me it looks like they have already developed the "graphical" part (table and skymap), while gamma-cat is best for the repository part. |
In addition, were the HESS and VERITAS data information cross-checked before entering the gamma-cat database? |
Some of the VERITAS data has been cross checked, but not all. This is indeed important. |
MAGIC is going to a) cross-check previous generate fits file, and possibly regenerate fits file, b) input the re-generate fits file in the format for gamma-cat. We discussed that we would like to define precisely (more than in the past) what and how to write. Things like energy threshold, moon status, tag for spectral fit, etc. All this needs definition. |
I think, we have to find an easy and in particular reliable way to maintain the overview about all relevant papers/ data and which of them have been cross checked and which not. I thought about writing an list like: I do not have any experience with such an project and how to maintain the overview as soon as many people start to development, hence: What do you think? |
@elisaprandini will also contribute to this issue with MAGIC |
@micheledoro @elisaprandini - It's great that you want to contribute MAGIC data to gamma-cat.
Data entry goes via "pull requests", so there is some review as data is added.
Ideally, yes, as much information as possible would be available in the files. But there also has to be a balance between usefulness of the information for most users of gamma-cat, and time spent to define what each piece of information means and to do and review the data entry. What we've done so far is to start simple, and keep adding fields of information as the use cases arise. We can and should add more information for a given measurement / paper, I just want to caution against the goal to be complete and get the data format schema right from the start. I think we have to improve iteratively and it's best to start small and simple. @pdeiml and I have started to write some information with the goal to help people get started with data entry for gamma-cat: If you want, we could also do a short Skype call where we discuss a bit and help you get started doing a first "pull request" with data entry for one MAGIC paper / source? |
@elisaprandini and I have checked all MAGIC TeVCat sources against those in gamma-cat, and found that the following published papers were not included:
Additionally we found the following unpublished discoveries:
@elisaprandini and I will try to include these one first. We will later on continue with: |
This issue gives an overview about all MAGIC publication which can be found here:
https://magic.mpp.mpg.de/backend/publications
i will update the list during the next days.
Firstly, the articles:
| 2017MNRAS.470.4608A | ? | n | n |
| 2017A&A...603A..29A | ? | n | n |
| 2017A&A...603A..31A | y | y | y |
| 2017A&A...602A..98A | y | n | n |
| 2017MNRAS.471.1688A | ? | n | n |
| 2017arXiv170803689M | y | n | n |
| 2017A&A...601A..33A | n | n | n |
These articles do not have a Reference_id:
https://magic.mpp.mpg.de/backend/publication/show/361
https://magic.mpp.mpg.de/backend/publication/show/369
I propose that someone should double check the papers I marked with 'not relevant' or with the questionmark which means that I am not sure whether the paper is relevant or not.
Additionally, one should check whether for the relevant papers data entry is done or not, if not, please make at least a dummy yaml file with a TODO remark in the corresponding folder.
Of course, edit the table entry when you did something.
The text was updated successfully, but these errors were encountered: