Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kodi image #199

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added Kodi image #199

wants to merge 4 commits into from

Conversation

Skerga
Copy link

@Skerga Skerga commented Nov 25, 2024

I created an image for Kodi i wanted to share.
I have not yet tested it extensively, but i got controller support working.

currently it builds only the joystick addon. If more addons are required its quite easy to add them.

@ABeltramo
Copy link
Member

Thanks for sharing this! 🚀

I've quickly skimmed through the files, is building from source really necessary? Have you tried using the ppa:team-xbmc/ppa from the official docs instead?

Do you really need to hardcode the Xbox controller layout? Wolf can also create a PS or Nintendo virtual joypad depending on the HW plugged on the Moonlight client.

@Skerga
Copy link
Author

Skerga commented Nov 26, 2024

there is no default Keybind included, so we would need to create one config per controller.
I need to check if i can make some config for the other controller types available, sadly i only own a Switch controller out of the list of missing ones.

the ppa isn't updated anymore since the sole maintainer left. https://kodi.wiki/view/HOW-TO:Install_Kodi_for_Linux
and there is no prebuild for our ubuntu version used by the base image.

Only other possibility would be using the prebuild from ubuntu's repo, but those are modified and don't include some parts to comply with the requirements of them.

@ABeltramo
Copy link
Member

I need to check if i can make some config for the other controller types available, sadly i only own a Switch controller out of the list of missing ones.

You should be able to force a joypad type from the config.toml: https://games-on-whales.github.io/wolf/stable/user/configuration.html#_override_the_default_joypad_mapping

the ppa isn't updated anymore

I didn't know about it.. Well, it was worth mentioning it just in case you've missed it!

@Skerga
Copy link
Author

Skerga commented Nov 27, 2024

All controller configs are now added. I only found two minor thing.

  • Kodi seems to think it crashes when exited via the menu, creating a crash report in the process.
  • The connection does not close automatically on exiting Kodi.

I'll look into that a bit more tomorrow but its nothing really breaking, if you just close it with the moonlight command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants