Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imageWithBlocks fix. Rotate the original image to the right or it sho… #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

imageWithBlocks fix. Rotate the original image to the right or it sho… #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion TesseractOCR/G8Tesseract.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,12 @@ - (NSData *)recognizedPDFForImages:(NSArray*)images {

- (UIImage *)imageWithBlocks:(NSArray *)blocks drawText:(BOOL)drawText thresholded:(BOOL)thresholded
{
UIImage *image = thresholded ? self.thresholdedImage : self.image;
UIImage *image = self.thresholdedImage;
if (!thresholded) {
// Have to rotate the original image to the right or it shows upside down
CGImageRef imageRef = self.image.CGImage;
image = [[UIImage alloc] initWithCGImage:imageRef scale:self.image.scale orientation:UIImageOrientationRight];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a universal PR. It only works in your case. What if the image is rotated to a different orientation?
Also any code, which is added to the repo should be test covered.
Would you mind adding tests for you code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible that this problem only occurs for me. I would appreciate if someone can tell me what did I do wrong. I passed Tesseract an image with horizontal text. Tesseract was able to recognize the text. Only problem is when I ask for imageWithBlocks, it gives back an image upside down, when the blocks are at the right location, as shown in the first image. And if I say use threshold, everything is fine. So my feeling is that the orientation of the self.threshold image is correct but self.image is wrong universally.
I will look into how to add test code.

}

UIGraphicsBeginImageContextWithOptions(image.size, NO, image.scale);
CGContextRef context = UIGraphicsGetCurrentContext();
Expand Down