-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing object type fix #82
Conversation
The validation directories are confusing & not part of the framework itself.
…esponse Removing mentions to "aggregated" granularity in the code.
…mnants removing the validation directories
`ResultsetInstance` was missing the "type" parameter which leads to errors when creating instances.
Yes, this can be considered a hotfix so I agree this is one of the case scenarios in which a PR directly to main is appropriate. |
I miss an update to Change.MD in order to notify the change. |
@jrambla The missing |
This is a pure documentation change for the handover format. Addresses #83
we need @jrambla approval here to close this PR |
This PR requires a review from the current status |
These are fixes that won't break the specification, just addressing examples for ageOfOnset, which were including the entry definitions (and the schema don't need to add this information), as well as adding object type for ResultSetInstance (and other format fixes). Still 1 pending review. |
Update schema-urgent-fixes branch to align with main
ResultsetInstance
was missing the "type" parameter which leads to errors when creating instances.Tis is an urgent fix w/o any changes to the schema etc. and IMO should directly go into
main
instead ofdevelop
etc.