Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] "Chance" configuration #84

Open
Disketaa opened this issue Sep 20, 2024 · 2 comments
Open

[Feature Request] "Chance" configuration #84

Disketaa opened this issue Sep 20, 2024 · 2 comments

Comments

@Disketaa
Copy link

image

Would be nice if there any configuration for "Chance" tooltip.
I imagine something like:

  • "Default" - Current variant
  • "Rounded" - Round percentage value from 311.1% -> 311%
  • "Weight" - Weight value instead of percentage
  • "Disable" - Off

Also it cool for better recognition / separation to make chance text darker than item name like so:
image

@fzzyhmstrs
Copy link
Owner

I will consider this, it should not be very hard to give some options, and I think the color change is a good idea.

@Disketaa
Copy link
Author

Disketaa commented Oct 2, 2024

Why my chances are displayed like "100%" for every entry in loot table?
image

{
  "type": "minecraft:fishing",
  "pools": [
    {
      "rolls": 1,
      "entries": [
        {
          "type": "minecraft:item",
          "name": "minecraft:tropical_fish",
          "weight": 75,
          "quality": -1
        },
        {
          "type": "minecraft:item",
          "name": "minecraft:cod",
          "weight": 30,
          "conditions": [
            {
              "condition": "minecraft:entity_properties",
              "entity": "this",
              "predicate": {
                "type_specific": {
                  "type": "minecraft:fishing_hook"
                },
                "location": {
                  "biomes": [
                    "minecraft:cold_ocean",
                    "minecraft:deep_cold_ocean",
                    "minecraft:deep_frozen_ocean",
                    "minecraft:deep_ocean",
                    "minecraft:frozen_ocean",
                    "minecraft:frozen_peaks",
                    "minecraft:frozen_river",
                    "minecraft:ice_spikes",
                    "minecraft:jagged_peaks",
                    "minecraft:river",
                    "minecraft:snowy_beach",
                    "minecraft:snowy_plains",
                    "minecraft:snowy_slopes",
                    "minecraft:snowy_taiga",
                    "minecraft:taiga",
                    "minecraft:windswept_forest",
                    "minecraft:windswept_gravelly_hills",
                    "minecraft:windswept_hills"
                  ]
                }
              }
            }
          ]
        },
        {
          "type": "minecraft:item",
          "name": "minecraft:salmon",
          "weight": 25,
          "conditions": [
            {
              "condition": "minecraft:entity_properties",
              "entity": "this",
              "predicate": {
                "type_specific": {
                  "type": "minecraft:fishing_hook"
                },
                "location": {
                  "biomes": [
                    "minecraft:cold_ocean",
                    "minecraft:deep_cold_ocean",
                    "minecraft:deep_frozen_ocean",
                    "minecraft:deep_ocean",
                    "minecraft:frozen_ocean",
                    "minecraft:frozen_peaks",
                    "minecraft:frozen_river",
                    "minecraft:ice_spikes",
                    "minecraft:jagged_peaks",
                    "minecraft:mangrove_swamp",
                    "minecraft:river",
                    "minecraft:snowy_beach",
                    "minecraft:snowy_plains",
                    "minecraft:snowy_slopes",
                    "minecraft:snowy_taiga",
                    "minecraft:swamp",
                    "minecraft:taiga",
                    "minecraft:windswept_forest",
                    "minecraft:windswept_gravelly_hills",
                    "minecraft:windswept_hills"
                  ]
                }
              }
            }
          ]
        },
        {
          "type": "minecraft:item",
          "name": "minecraft:pufferfish",
          "weight": 10,
          "conditions": [
            {
              "condition": "minecraft:entity_properties",
              "entity": "this",
              "predicate": {
                "type_specific": {
                  "type": "minecraft:fishing_hook"
                },
                "location": {
                  "biomes": [
                    "minecraft:beach",
                    "minecraft:cold_ocean",
                    "minecraft:deep_cold_ocean",
                    "minecraft:deep_ocean",
                    "minecraft:frozen_ocean",
                    "minecraft:lukewarm_ocean",
                    "minecraft:ocean",
                    "minecraft:warm_ocean"
                  ]
                }
              }
            }
          ]
        }
      ]
    }
  ],
  "random_sequence": "minecraft:gameplay/fishing/fish"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants