How do implement a "hook" to take screenshot on Error automatically

[lehmannk]

Currently, convenience test does not take a log screenshot when e.g. assertion or execution errors occur. Now, instead of capsulating everything with try - catch blocks etc, is there a convenient way to let convenience test automatically create a log screenshot in these cases, e.g. through FlutterError.onError

[fzyzcjy]

Firstly, is there screenshot for the item above the error?

Secondly, currently there are some snapshots when some kind of errors happen, e.g.

flutter_convenient_test/packages/convenient_test_dev/lib/src/functions/find.dart

Line 281 in 2dfee87

await log.snapshot(name: 'failed');

.

[lehmannk]

Ah, I think I see the problem. While convenience test extends all "native" finders and commands in https://github.com/fzyzcjy/flutter_convenient_test/blob/2dfee8760b820e3951de7dceb4edc96c14cc6980/packages/convenient_test_dev/lib/src/functions/find.dart

I am using PatrolFinder instead to locate and operate controls (because these are way easier to use). For PatrolFinder there is no extension in convenience test. So would you suggest copying convenience test`s find.dart
and adapting everything for PatrolFinder or is there an easier way to integrate another 3rd party finder lib?

[fzyzcjy]

Hmm, good question! I agree there needs to be some code that glues the two together. As for easier adaption, maybe we can abstract away the common parts a little bit.

[lehmannk]

As a first step I copied convenience test`s find.dart and created these new extensions

extension PatrolFinderExtension on PatrolFinder {
...
Future<void> tap({SettlePolicy? settlePolicy, Duration? visibleTimeout, Duration? settleTimeout}) =>
      PatrolFinderCommandExtension.auto(this)
          .tap(settlePolicy: settlePolicy, visibleTimeout: visibleTimeout, settleTimeout: settleTimeout);
...
}

with

class PatrolFinderCommandExtension extends TCommand {
...
 Future<void> tap({
    SettlePolicy? settlePolicy,
    Duration? visibleTimeout,
    Duration? settleTimeout,
  }) =>
      act(
        act: (log) => tap(settlePolicy: settlePolicy, visibleTimeout: visibleTimeout, settleTimeout: settleTimeout),
        preCondition: ElementHitTestableMatcher(t.tester),
        logTitle: 'TAP',
        logMessage: finder.describeMatch(Plurality.one),
        settle: settleTimeout != null,
      );
...
}

where the tap methode references PatrolFinder's tapmethod. But my test code with the PatrolFinder tap() method does not run into this extension. What else is required to connect the extension with convenience test runs?

[fzyzcjy]

But my test code with the PatrolFinder tap() method does not run into this extension

A first debugging may be, click through all the functions and see which one calls which one (e.g. ctrl-click, or any hotkey you use). For example, a quick look seems that the (log) => tap(...) may be a recursive call (surely I can be wrong - since I look at it by eyes instead of using an IDE)

[lehmannk]

Ok, I think I found a way. I need to extend both PatrolFinder (in order to map PatrolFinder to ConvenienceTest finders) as well as TFinderCommand in order to actually implement PatrolFinder commands instead of ConvenienceTest commands such as tap() etc... A bit fiddly but it works :-)