fixed nonetype issue in vendor tax (#128)

* fixed nonetype issue in vendor tax * fixes to vendor tax * Bump Version
fylein · Apr 30, 2024 · 33ba398 · 33ba398
1 parent 9a9bd64
commit 33ba398
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/netsuitesdk/api/vendor_bills.py b/netsuitesdk/api/vendor_bills.py
@@ -124,11 +124,12 @@ def post(self, data) -> OrderedDict:
         if 'taxDetailsOverride' in data:
             vb['taxDetailsOverride'] = data['taxDetailsOverride']
 
-        if 'taxDetailsList' in data:
+        if 'taxDetailsList' in data and data['taxDetailsList']:
             tax_details_list = []
-            for tdl in data['taxDetailsList']['taxDetails']:
-                tax_details_list.append(self.ns_client.TaxDetails(**tdl))
-            vb['taxDetailsList'] = self.ns_client.TaxDetailsList(taxDetails=tax_details_list)
+            if 'taxDetails' in data['taxDetailsList']:
+                for tdl in data['taxDetailsList']['taxDetails']:
+                    tax_details_list.append(self.ns_client.TaxDetails(**tdl))
+                vb['taxDetailsList'] = self.ns_client.TaxDetailsList(taxDetails=tax_details_list)
 
         logger.debug('able to create vb = %s', vb)
         res = self.ns_client.upsert(vb, 'bills')

diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name='netsuitesdk',
-    version='2.21.2',
+    version='2.21.3',
     author='Siva Narayanan',
     author_email='[email protected]',
     description='Python SDK for accessing the NetSuite SOAP webservice',