Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper implementation of Pushing #125

Open
3 tasks done
EmptyOwl01 opened this issue Jan 30, 2023 · 2 comments
Open
3 tasks done

Improper implementation of Pushing #125

EmptyOwl01 opened this issue Jan 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@EmptyOwl01
Copy link

Describe the bug

I notice that pushing is not quite correct in the T2k4e implementation as well, since you can (technically) reroll base dice with successes and this is not allowed in the Foundry ruleset.

Reproduction

Roll some dice, get at least a success on one or both dice, Push the roll (if you even can).

System Info

windows

Logs

No response

Priority this issue should have?

Medium (minor functional impact)

Validations

  • Done a clean install of the system.
  • Disabled all modules.
  • Checked if the issue is present in a new world instance (create a new world in foundry using the Twilight 2000 system).
@EmptyOwl01 EmptyOwl01 added the bug Something isn't working label Jan 30, 2023
@Stefouch
Copy link
Member

Roll mechanics have been updated since then. It should be good.

@Stefouch
Copy link
Member

Reopened as there was a confusion and I think this issue has not been resolved yet.

Fortunately, the Blade Runner RPG has already implemented the ability to reroll specific dice here:
https://github.com/fvtt-fria-ligan/blade-runner-foundry-vtt/blob/8b55097c9be73fdc100cc82b3e5de95f32f42b89/src/components/roll/roller.js#L433
This might help.

@Stefouch Stefouch reopened this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants