Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matrix-matrix and matrix-matrix-matrix product #15

Closed
fverdugo opened this issue Jan 18, 2021 · 5 comments
Closed

Implement matrix-matrix and matrix-matrix-matrix product #15

fverdugo opened this issue Jan 18, 2021 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@fverdugo
Copy link
Owner

This would be needed for multigrid preconditioners.

@fverdugo fverdugo added the help wanted Extra attention is needed label Jan 18, 2021
@stevengj
Copy link

stevengj commented Nov 18, 2021

Wouldn't you generally want to leave such products implicit, ala https://github.com/JuliaSmoothOptimizers/LinearOperators.jl, i.e. A * B returns an operator that computes (A * B) * x via A * (B * x)?

That being said, matrix–matrix products are nice to have in general.

@carlodev
Copy link

I would try to implement this feature. I was looking at the PSparseMatrix and PVector product. Do you have any suggestions on where I can start from? or reference to better understand how the code/package internally works (I get lost in the indexing notation)?

@fverdugo
Copy link
Owner Author

Hi Carlos, I am refactoring the code with the main objective of improving the documentation so that others can contribute easier.

See the work going on in branch https://github.com/fverdugo/PartitionedArrays.jl/tree/remove_abstractpdata

(the name is a bit confusing, sorry...)

If you are not in a hurry, it would better to wait.

In the meanwhile, you can build and read the documentation in the branch and start providing feedback for the parts that are relatively mature (parallel primitives and partitioned ranges).

@stevengj
Copy link

@fverdugo, can you link the commit where this was completed?

@fverdugo
Copy link
Owner Author

Yes, I should have mentioned this, while closing the issue.

It was in PR #134 as part of the implementation of smoothed aggregation AMG solvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants