Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPublicKeyFromSignature should allow compressed=true to be passed. #173

Open
radicleart opened this issue Mar 13, 2023 · 3 comments
Open

getPublicKeyFromSignature should allow compressed=true to be passed. #173

radicleart opened this issue Mar 13, 2023 · 3 comments

Comments

@radicleart
Copy link

Using:
"micro-stacks": "^1.1.4",
"@noble/secp256k1": "^1.7.1"

Comparing getPublicKeyFromSignature from "micro-stacks/connect" to recoverPublicKey from '@noble/secp256k1'

The latter allows the flag compressed=true to be passed whereas the former hard codes it to false.

The recoverPublicKey recovers the correct pubkey / stxAddress from a signature signed with getOpenSignMessage from '@micro-stacks/svelte whereas incorrect pubkey returned from getPublicKeyFromSignature .
@radicleart radicleart mentioned this issue Mar 13, 2023
Closed
@radicleart
Copy link
Author

Linked issue - needed to remove ref. to common js modules in api as this is not supported in Scure/btc-signer. See paulmillr/scure-btc-signer#32

@aulneau aulneau mentioned this issue Mar 20, 2023
Open
@aulneau
Copy link
Contributor

aulneau commented Mar 20, 2023

sorry, can you be more specific -- I have a PR here that will let you pass it. is this what you need? #176

@radicleart
Copy link
Author

Yes believe 176 is all that's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radicleart @aulneau