Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text position, orientation (& donut hole radius) #47

Open
Jeehut opened this issue Sep 19, 2023 · 1 comment
Open

Text position, orientation (& donut hole radius) #47

Jeehut opened this issue Sep 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Jeehut
Copy link
Contributor

Jeehut commented Sep 19, 2023

@fummicc1 First of all: Thank you for this awesome library!

When I used this library to create a simple "roulette" with characters, I noticed a couple of drawbacks that make it not look like a "real" roulette and pretty much feel like an incomplete implementation:

  1. The letters I put into the parts are placed somewhere close to the middle of each part instead of at the outer end.
  2. The orientation of the text was looking into the same direction for each text, very unlike in a real roulette.

Here's an example state after I stopped my roulette (note that I reduce the opacity in the "stopped" state):
Bildschirmfoto 2023-09-19 um 09 02 03

And here's an actual roulette where everything looks as expected (letters at outer end, oriented to the direction of the part):
image

I understand that different people might have different use cases, but I would expect a library called "roulette" to at least have the option to render like most roulettes are designed. Would be great to have these options added!

P.S. A third thing I would love to see is to define a radius for the middle part where there are no lines drawn, as the lines all coming together in the middle looks a bit weird and stresses the eye especially when rotating. Again, like in the real roulette design I've added above, where the middle part has no lines for a reason.

@Jeehut Jeehut changed the title Text position & orientation Text position, orientation (& donut hole radius) Sep 19, 2023
@fummicc1 fummicc1 self-assigned this Sep 24, 2023
@fummicc1 fummicc1 added the enhancement New feature or request label Sep 24, 2023
@fummicc1
Copy link
Owner

fummicc1 commented Oct 5, 2023

I'm sorry for late reply. I am surprised to receive such a detailed feedback.
Honestly, I don't use this library in my any application for now, so I didn't consider if this library can take part of real Roulette or not.
your feedback is perfectly true from my side but 1st and 3rd feature you mentioned can be breaking change as you know.
so I will address this issue except for 2nd one later (also need to take time to decide specs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants