From 8c4d355741356c92cda331ff567cda4b4705c8f9 Mon Sep 17 00:00:00 2001 From: Adam Shaw Date: Thu, 1 Feb 2024 12:38:58 -0500 Subject: [PATCH] better solution for IDE dependencies --- .vscode/settings.json | 6 ++++-- package.json | 9 --------- packages/temporal-polyfill/package.json | 8 +++++++- pnpm-lock.yaml | 5 +---- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index a3f62b6d..cbddd936 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,10 +1,12 @@ { - "typescript.enablePromptUseWorkspaceTsdk": true, "editor.rulers": [80], "editor.formatOnSave": true, "editor.defaultFormatter": "biomejs.biome", "editor.codeActionsOnSave": { "quickfix.biome": "explicit", "source.organizeImports.biome": "explicit" - } + }, + "typescript.enablePromptUseWorkspaceTsdk": true, + "typescript.tsdk": "node_modules/.pnpm/typescript@5.3.3/node_modules/typescript/lib", + "biome.lspBin": "node_modules/.pnpm/@biomejs+biome@1.5.1/node_modules/@biomejs/biome/bin/biome" } diff --git a/package.json b/package.json index 4c0a907c..05517780 100644 --- a/package.json +++ b/package.json @@ -25,17 +25,8 @@ "clean": "pnpm -r run clean" }, "devDependencies": { - "@biomejs/biome": "1.5.1", "lefthook": "^1.6.1" }, - "devDependenciesNotes": { - "@biomejs/biome": [ - "NOTE: Specifically for IDE. Command line uses versions in sub-packages", - "NOTE: Always keep sub-packages up-to-date", - "BUG: Pinned on 1.5.1 due to this regression in 1.5.3:", - "https://github.com/biomejs/biome/issues/1654" - ] - }, "pnpm": { "patchedDependencies": { "rollup-plugin-sourcemaps@0.6.3": "patches/rollup-plugin-sourcemaps@0.6.3.patch" diff --git a/packages/temporal-polyfill/package.json b/packages/temporal-polyfill/package.json index 170dea33..0684b331 100644 --- a/packages/temporal-polyfill/package.json +++ b/packages/temporal-polyfill/package.json @@ -99,8 +99,14 @@ "rollup-plugin-dts": "^6.1.0", "rollup-plugin-sourcemaps": "^0.6.3", "terser": "^5.27.0", - "typescript": "^5.3.3", + "typescript": "~5.3.3", "vitest": "^1.2.2", "yargs": "^17.7.2" + }, + "devDependenciesNotes": { + "@biomejs/biome": [ + "BUG: Pinned to 1.5.1 due to this regression in 1.5.3:", + "https://github.com/biomejs/biome/issues/1654" + ] } } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 500434de..c7418af1 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -13,9 +13,6 @@ importers: .: devDependencies: - '@biomejs/biome': - specifier: 1.5.1 - version: 1.5.1 lefthook: specifier: ^1.6.1 version: 1.6.1 @@ -133,7 +130,7 @@ importers: specifier: ^5.27.0 version: 5.27.0 typescript: - specifier: ^5.3.3 + specifier: ~5.3.3 version: 5.3.3 vitest: specifier: ^1.2.2