Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General question of using third party libraries? #53

Open
sagikazarmark opened this issue Oct 22, 2014 · 3 comments
Open

General question of using third party libraries? #53

sagikazarmark opened this issue Oct 22, 2014 · 3 comments

Comments

@sagikazarmark
Copy link
Contributor

We started this in the Pagination issue, but I think it might be continued.

I agree with the argument that we shouldn't rely on too much third-party packages. That's true.

But there are some cases (like Pagination I think) where the functionality is not really part of the framework, it is just an extra. Reinventing the wheel is not an option.

Some examples where using third-party should be at least considered:
Asset
Date
Image
Pagination
Profiler/Debug*

  • Mentioning here, but any third party needs heavy integration of course.

I know some of these have already been addressed to use a third-party.

@felipsmartins
Copy link

I think só too! Pagination class should be a third part, as @sagikazarmark said, it's a just an extra, a component.

@WanWizard
Copy link
Contributor

There are a lot of considerations to be taken into account, so it's not that simple.

  • Is there a third party component available that covers the requirements?
  • Are we willing to accept a difference in features vs requirements?
  • Are we willing to wrap it in case not all requirements are covered?
  • How stable and well-maintained is it?
  • What is the third-party's acceptable level of community contributions?
  • In case of unresolved issues, are we willing to fork it and maintain it ourselfs?
  • If not, are we capable of writing and maintaining it ourselfs?
  • Can we deal with the complexities?

In case of Image there are several candidates that are well estabilished, in case of Asset probably as well. Our Date class is pretty special, I haven't seen any replacement that covers the same requirements, Pagination is quite specific in terms of interfaces with other components, And our Debug is better than what is out there.

@kenjis
Copy link

kenjis commented Oct 24, 2014

@WanWizard
That's a good point. They are all case by case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants