Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a security package #14

Open
WanWizard opened this issue Feb 25, 2013 · 5 comments
Open

Create a security package #14

WanWizard opened this issue Feb 25, 2013 · 5 comments

Comments

@WanWizard
Copy link
Contributor

I think FuelPHP needs a separate security package, that will contain all classes and method related to security:

  • Crypt
  • Validation and cleaning
  • CSRF protection
  • PHPSecLib

There is a composer package for PHPSecLib. Biggest problem is that it's loaded with trigger_error()/user_error() calls instead of exceptions, which kinda sucks...

There is already some security code in the Foundation package, this will have to move too. This also means there won't be a need for a separate Crypt package.

@WanWizard
Copy link
Contributor Author

I think we can add FTP functionality to this package too.SFTP is already provided by PHPSecLib.

This was referenced Mar 8, 2013
@davispuh
Copy link

davispuh commented Mar 8, 2013

well tbh I think Security and FTP aren't kinda related. For me seems kinda out of scope and maybe better would be Networking package for FTP/SFTP etc? and that could depend on Security for some features.

@frankdejonge
Copy link
Contributor

I agree with @davispuh, the ftp package should have a dependency on the security package, or just the one lib. Nothing more. Would be odd to place it here.

@WanWizard
Copy link
Contributor Author

But then again neither does SFTP. or SSH, or... I can live with a generic Networking package and a Security package, both requiring PHPSecLib, with the former exposing SFTP and SSH.

@sagikazarmark
Copy link
Contributor

I'm not telling to use third-party again, just mentioning this library.

https://github.com/padraic/SecurityMultiTool

Has a very good list about security tools which might be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants