Reflect parentheses that discard extra values in the AST #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstirlitz
force-pushed
the
master
branch
3 times, most recently
from
24840d1 to
5015784
Compare
The parentheses are represented as a UnaryExpression with the empty string as the operator. This choice minimises compatibility breaks: users only need to add precedence information and/or identity evaluation for a new operator. Serialising code that assumes all unary operators have the same precedence bested only by the power operator, and otherwise treats them as black boxes, should keep working correctly, even in the presence of the latter. Parentheses on the LHS of assignment are not represented unless nested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parentheses are represented as a UnaryExpression with the empty string as the operator. This choice minimises compatibility breaks: users only need to add precedence information and/or identity evaluation for a new operator. Serialising code that assumes all unary operators have the same precedence bested only by the power operator, and otherwise treats them as black boxes, should keep working correctly, even in the presence of the latter.
Parentheses on the LHS of assignment are not represented unless nested.
This fixes #79.