Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp QA suite #54

Open
oxyc opened this issue Aug 6, 2017 · 1 comment
Open

Revamp QA suite #54

oxyc opened this issue Aug 6, 2017 · 1 comment
Labels
enhancement Request for functionality covering an entirely new use case testsuite
Milestone

Comments

@oxyc
Copy link
Collaborator

oxyc commented Aug 6, 2017

A lot of the QA suite was experimentations on my part, but I think it could be loosened now.

  • Drop support (or at least testing) for ancient JavaScript engines.
  • Drop complexity analysis. Or just print it without failing.
  • I think we should still keep test coverage analysis and fail if there's a reduction.
  • Maybe drop jshint and adopt prettier so contributors don't need to care about code standards. To me which convention doesn't matter as long as there is one.
  • Should make it easier and better documented how to scaffold tests.
  • I have nothing against spec as a testing framework but if we drop support for ancient JavaScript engines this is also open for discussion. Eg. ava which is async. But as spec works and is fast enough imo, I don't see much worth changing it.
  • Definitely drop testem, unless it's easy to add browser testing I think node testing would be enough for luaparse.
  • Is it possible to drop the UMD wrapper and use some library that wraps everything during the build step? Luaparse shouldn't be keeping it up to date.

Thoughts?

@ghost
Copy link

ghost commented Aug 10, 2017

Should make it easier and better documented how to scaffold tests.

Really this will help me a lot to pull request again...

@fstirlitz fstirlitz added enhancement Request for functionality covering an entirely new use case testsuite labels Aug 5, 2019
@fstirlitz fstirlitz added this to the 0.4 milestone Oct 5, 2019
@fstirlitz fstirlitz modified the milestones: 0.4, 0.5 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for functionality covering an entirely new use case testsuite
Projects
None yet
Development

No branches or pull requests

2 participants