Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Outlining -> FSharp.Editing #1409

Open
cloudRoutine opened this issue Jul 13, 2016 · 0 comments
Open

Outlining -> FSharp.Editing #1409

cloudRoutine opened this issue Jul 13, 2016 · 0 comments

Comments

@cloudRoutine
Copy link
Contributor

cloudRoutine commented Jul 13, 2016

If we want to move the hint text generation into core to enable other editors to take advantage of this feature we cannot depend on SnapshotSpan, SnapshotPoint, ITextSnapshotLine, ITextDocument, the ProjectProvider etc. If we send the text of the file's snapshot to Core this should work, dirty or not.

The Outlining functionality in Core will generate a collection of a type similar to ScopeRange that includes the hint text and hint range/span which will be sent back to the Logic/VsIntegration side. Most of the code in createTagSpan will need to move into Core except creating the buffer and the TagSpan. Logic/VsIntegration project will still handle the filtering, tag generation, and tooltips, but ScopeSpan should probably be changed to store the hint text that way createTagSpan becomes a simple transformation function to the data shape that VS requires.

It could be worthwhile to move the filtering to Core in the future if we decide to enable passing it configuration settings, but this is not a priority.

Code Located @
https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharp.Editing.VisualStudio/Outlining/OutliningTagger.fs

@cloudRoutine cloudRoutine added this to the VFPT.Core Refactoring milestone Jul 13, 2016
@cloudRoutine cloudRoutine changed the title Outlining -> VFPT.Core Outlining -> FSharp.Editing Jul 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant