Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse should stop smartly detecting the root of the project via VCS #482

Closed
carmenbianca opened this issue Jan 23, 2022 · 3 comments
Closed
Labels
wontfix This will not be worked on

Comments

@carmenbianca
Copy link
Member

It's a nifty QOL feature, but it's high in astonishment, and I think it makes supporting fsfe/reuse-docs#90 slightly harder.

@mxmehl
Copy link
Member

mxmehl commented Jan 24, 2022

Hm, but that would cause errors when running reuse lint in a sub-directory of a project, right?

@mxmehl
Copy link
Member

mxmehl commented Jun 2, 2022

We agreed that the tool should continue being aware of the VCS root. Unlike other linting tools, REUSE's scope is strictly project-wide, and not limited to single files or sub-directories.

That is why the tool needs to pick up certain information that has to be in the root of the repository, most notably .reuse/dep5 and LICENSES, but also .gitignore. If the tool was unaware of this, users of a compliant repository would get a non-compliant result if they were running reuse lint in a subdirectory. We agreed that we don't want to confuse users this way.

Instead, we should fix bugs like #281 where the behaviour of lint and download differ, and provide the option to only lint specific directories and files.

@mxmehl mxmehl closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
@mxmehl mxmehl added the wontfix This will not be worked on label Jun 2, 2022
@mxmehl
Copy link
Member

mxmehl commented Jun 2, 2022

Oh, forgot to note: @floriansnow brought up the idea of converting all paths internally to absolute first to lower the coding pain. @carmenbianca noted that this might make sense but certainly require a larger refactoring. If someone wants to work on this, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants