navigation.subscribe callback called twice #187

kmkr · 2020-05-28T13:06:14Z

We use the navigation.subscribe method to log page views to Google Analytics. The callback we pass to the subscribe method runs twice every time a user clicks an internal link on the page, and we end up sending double page views. Any idea why that happens ?

Here's how we use it, slightly simplified:

// ...
const navigation = createBrowserNavigation({
  context: rootNaviContext,
  url: window.location.href,
  routes,
});
hydrate(
  <Router navigation={navigation}>
    <Web>
      <Body />
    </Web>
  </Router>,
  document.getElementById('root'),
  () => {
    logGaPageView(route.url.href); // logs initial page view
    navigation.subscribe(route => {
       logGaPageView(route.url.href); // logs subsequent page views twice!
    });
  },
);

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

navigation.subscribe callback called twice #187

navigation.subscribe callback called twice #187

kmkr commented May 28, 2020

navigation.subscribe callback called twice #187

navigation.subscribe callback called twice #187

Comments

kmkr commented May 28, 2020