mypy: error: invalid syntax [syntax] at frictionless/dialect/types.py:28

[amotl]

Dear @roll,

first things first: Thank you so much for conceiving and maintaining Frictionless. It is true gold.

At daq-tools/skeem#10, we believe we are being tripped by a similar issue already reported at GH-1580 by @aborruso.

At our end, it is the mypy type checker, which fails like:

$ mypy skeem
.venv/lib/python3.10/site-packages/frictionless/dialect/types.py:28: error: invalid syntax  [syntax]
Found 1 error in 1 file (errors prevented further checking)

... when upgrading to frictionless-5.14.x already:

pip install --upgrade "frictionless<5.15"

On the other hand, when downgrading to frictionless-5.13.x:

pip install --upgrade "frictionless<5.14"

... mypy succeeds again:

mypy --install-types --non-interactive skeem
Success: no issues found in 36 source files

With kind regards,
Andreas.

P.S.: We are using the most recent mypy 1.5.1:

$ mypy --version
mypy 1.5.1 (compiled: yes)

[amotl]

When upgrading to frictionless-5.15:

pip install --upgrade "frictionless<5.16"

mypy fails like displayed at the CI run of Skeem ¹:

$ mypy --install-types --non-interactive skeem
error: --install-types failed (no mypy cache directory)

python/mypy#10768 indicates that this invocation and error report may mask the original error.

Footnotes

1. https://github.com/daq-tools/skeem/actions/runs/6373504098/job/17297271189?pr=10#step:5:21 ↩

[amotl]

python/mypy#10768 indicates that this invocation and error report may mask the original error.

Indeed. I only received the error on a fresh checkout, i.e. without an existing .mypy_cache directory. When it is present (mkdir .mypy_cache), the error goes back to:

site-packages/frictionless/resource/types.py:14: error: invalid syntax  [syntax]

... as outlined above.