Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't stopPropagation. #24

Open
hitsthings opened this issue May 24, 2012 · 2 comments
Open

Please don't stopPropagation. #24

hitsthings opened this issue May 24, 2012 · 2 comments

Comments

@hitsthings
Copy link

I want to handle events at the document level, but your stopEvent() function is extremely aggressive. Could you preventDefault without stopping propagation? Do you even need to preventDefault since the elements are all spans, it shouldn't have any default effect.

Otherwise, I don't really understand why you need to stop the event from progressing normally.

Thanks!

@freqdec
Copy link
Owner

freqdec commented May 24, 2012

Probably old code left over from when the drag handle was a link. Shall look into it. Thanks.

@LaurentGoderre
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants