Task in mesh_fastd to disable fastd always has state "changed"

[AiyionPrime]

This task is marked as changed on all supernodes, on every run.
Possible questions:

• What reenables 'fastd.service'?
• Does the service module set changed properly at all on disabling of services?

https://github.com/freifunkh/ansible/blob/master/roles/ffh.mesh_fastd/tasks/install.yml#L11-L12

[AiyionPrime]

I've talked to 1977er about this yesterday, currently we are installing fastd which brings a service with a vendor preset called fastd as well.
We then try to disable it, then later overwrite it with our own unitfile.

What exactly ansible thinks is changed is not clear, yet.
What is clear to us, is that it'd be cleaner to have our service file not called fastd, but fastd_ffh or ffh_fastd.

This would make it clearer, what service should run, not depending on its contents.

[AiyionPrime]

Furthermore, I think we should then not instal fastd and one step later disable its default service,
but deploy a preset file on our own. https://manpages.debian.org/stretch/systemd/systemd.preset.5.en.html

This should allow us to tell systemd not to start fastd befor fastd is even installed.
That would get rid of that nasty upgrade problem @1977er talked about as well.

Der fastd service wird ja auch bei jedem Upgrade wieder aktiviert. (something like that, not a real quote)

[AiyionPrime]

Ouch, I just saw a piece of code, that gets rid of init.d/fastd; this is hopefully not the only shipped service file :D

[AiyionPrime]

Still shipped, but there's a /lib/systemd/system/[email protected] as well.

[AiyionPrime]

btw, there's then a possible related and unresolved issue in ansible ansible/ansible#29506