-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEMlib - GEM API conformance (functions only) #23
Comments
Patch to add appl_options (XaAES) and wind_sget (N.AES): [EDIT] Includes both appl_options and wind_sget (previously only appl_options) |
Note about objc_data (who created this ###?)
Instead of a single objc_data() binding, there is (at least!) one binding for each 'request' value :
|
IMHO objc_data is really useless, and i'm quite sure that nobody uses it. All that is done there could be done in the application, too, without relying on the function being present. And since XaAES is probably the only AES with that function, you have to resort to such a fallback anyway. So instead of adding lots of bindings to gemlib, we should rather think about disabling that function. |
I totally agree. My goal is to make XaAES compatible with existing AES (and add gemlib with functions that are actually used by others AES/VDI to detect missing features), not to add extra unused functionality. Moreover, this function does not really bring anything and I just discover at the moment a lot of unused defines (OBSET_OBTYPE, OBSET_STRING, ...). Disable or delete, which is better? |
Would be easier to just disable it, but of course with git it's always easy to revert removed code. |
Patch for appl_options applied now, with 2 minor changes:
|
Thanks |
I've just added (hopefully) all geneva declarations and functions. Documentation is a bit incomplete (but it is available in tos.hyp) Maybe you want to take a look if there are any errors. |
Thanks a lot, I'll take a look at the weekend.
Patch to disable objc_data:
|
I did not find any error and I confirm |
Here is a patch to get rid of a lot of TODO in |
@xdelatour the patch above seems to be already applied (sorry for my late response). Just be careful with trailing spaces, I see quite a few of them introduced in 090db4d. |
Yes, patch already applied by Thorsten |
Patch for mt_gemx.h: |
Applied, one less item off your TODO list. ;-) |
Thank you! About wind_apfind, I wonder if it's really useful to add it. I don't want to add bloatware in xaaes (it's already too big). Maybe I can just add its description in tos.hyp. It is by doing tests under MultiGEM II that I discovered that the desktop pid is 0. |
Missing bindings
AES
XaAES (tos.hyp and source)
N.AES (naesbind.h)
MyAES (undoc.)
PC-GEM (seasip.info)
FreeGEM (OpenGEM on github - for info only)
MultiGEM II
Geneva (tos.hyp)
VDI
TOS (tos.hyp - available in Pure C bindings. GEM/1 only. Replaced by vsp_film, vqp_filmname and vsc_expose)
NVDI (tos.hyp)
FSM/Speedo (bindings?)
Other
Sound - (freemint/tos.hyp#101)
Matrix (bindings?)
PC-GEM (tos.hyp)
Note about PC-GEM:
The text was updated successfully, but these errors were encountered: