From 2648c64f0f43a4fd23c1f750337d4f7c9dc5e9b6 Mon Sep 17 00:00:00 2001 From: Gabriel Ittner Date: Mon, 25 Sep 2023 11:10:26 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Kirill Boyarshinov <1917615+kboyarshinov@users.noreply.github.com> --- CHANGELOG.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f8d30fe66..90172dbb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,15 +17,15 @@ Change Log - **Breaking**: Renamed the Compose `@ComposeDestnation` annotation to `@NavDestination` and the Fragment `@ComposeDestination` to `@ComposeFragmentDestination`. -- **Breaking**: Removed `@ScopeTo` and `ForScope` annotations. They have been replaced by +- **Breaking**: Removed `@ScopeTo` and `@ForScope` annotations. They have been replaced by Anvil's `@SingleIn` and `@ForScope` from `com.squareup.anvil:annotations-optional`. -- New: The code generation now supports KSP. The functionality is generally the same -- New: A new `@NavHostActivity` annotation was added and will generate an `Activity` and the +- **New**: The code generation now supports KSP. The functionality is generally the same +- **New**: A new `@NavHostActivity` annotation was added and will generate an `Activity` and the related boilerplate. Check out [the docs](https://freeletics.github.io/khonshu/codegen/) for more details. - It's now possible to use both `@NavDestination` and `@ComposeFragmentDestination` at the same time on the same composable. This allows transitioning from Fragments to Compose more easily. -- Removed: `@RendererScreen` and `@ComposeScreen` annotations. These allowed generating Fragments +- **Removed**: `@RendererScreen` and `@ComposeScreen` annotations. These allowed generating Fragments and Composables without relying on Khonshu navigation. We've only ever used this for Activities which now have a better solution. In the beginning we saw the codegen and navigation as 2 separate things but now the codegen is more of an add-on, so we decided to remove the standalone