Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the volume's default regex to allow optional dot at the end of the volume #110

Open
quevon24 opened this issue Aug 3, 2022 · 2 comments

Comments

@quevon24
Copy link
Member

quevon24 commented Aug 3, 2022

After inspection wrong CL imports related to bad citations, I found that many of them are almost correct, the problem with those citations it that it has a dot after the volume number, one solution is to lean on opinionated by creating citation fixes, the problem with this is that it will take a lot of effort just to remove a dot.

Here are some examples:

139. So. 925 -- > 139 So. 925
144. Pac. 93 --> 144 Pac. 93
149. So. 573 --> 149 So. 573
174. S.E. 235 --> 174 S.E. 235
205. N. W. 661 --> 205 N. W. 661

I propose to update the default volume regex: "(?P<volume>\d+)" to allow an optional dot after the volume number.

Do you see it feasible? Or which path should be taken for these citations?

@mlissner
Copy link
Member

mlissner commented Aug 3, 2022

That seems fine to me in theory, but I wonder if doing this first would be good: freelawproject/eyecite#117

@flooie
Copy link
Contributor

flooie commented Aug 3, 2022

@mlissner sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants