Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move make update-pip-requirements back into development containers #7245

Open
cfm opened this issue Oct 11, 2024 · 1 comment · May be fixed by #7400
Open

move make update-pip-requirements back into development containers #7245

cfm opened this issue Oct 11, 2024 · 1 comment · May be fixed by #7400
Assignees
@legoktm

Comments

@cfm
Copy link
Member

cfm commented Oct 11, 2024

After I initially reviewed #7234, @legoktm added in #7234 (comment):

I'm gonna make one change, we don't actually need to run this in the container anymore, so it'll be even faster.

I didn't retest with that change, and we've just discovered why I should have: without the container, the available system Python is what's used to build packages, and apxs is required from the apache2-dev package. @legoktm thinks these are reasons to move make update-pip-requirements back into the development containers after all.
@legoktm
Copy link
Member

legoktm commented Oct 11, 2024

apxs is just its own weird thing that we need to handle, but the funny thing is if we embraced uv even farther, it could automatically download Python 3.8 for us if missing instead of falling back to whichever system Python is available.

Maybe there's a fast path of like, if you have everything we need, skip the container. But probably not worth the extra hassle/logic.

@legoktm legoktm moved this to Ready to go in SecureDrop dev cycle Oct 11, 2024
@legoktm legoktm self-assigned this Dec 20, 2024
legoktm added a commit that referenced this issue Dec 20, 2024
@legoktm
Run make update-python3-requirements in the dev container (again)
75a9900 
Some packages, especially mod-wsgi, have dependencies on system packages
and cannot universally be run on the host.

Moving it back into the container will be a bit slower, but overall it
should still be noticibly faster than pre-uv.

Fixes #7245.
@legoktm legoktm linked a pull request Dec 20, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legoktm legoktm

Labels
None yet
Projects
SecureDrop dev cycle
Status: Ready to go
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run make update-python3-requirements in the dev container (again) freedomofpress/securedrop
2 participants
@legoktm @cfm