Nested Icons Displaying Small

[ninavizz]

Problem

@kushaldas implemented the eye-icon within passphrase fields (PR #659), and @ntoll implemented our lovely spinner icon as an active-state within the Print and Export flows (PR #940 ).

In both instances, icons were correctly spec'd to size per the Zeplin mockups—however they displayed too small. Both Kushal and Nicholas explored rectifications, as well as sizing both assets absurdly large—and both observed QT's desire to constrain the icon size in both situations.

One is an animation, the other is a static SVG—so formatting of the image asset does not appear to be an issue.

Solution

Post-Beta, it'd be great to investigate why this is happening—and to rectify both of the above named situations. It is wonderful to have both bits of functionality, and as of this writing they simply "appear odd" vs broken or un-usable. FYI for prioritization.

[ntoll]

Heads up...

The QPushButton class has a setIconSize method (https://doc.qt.io/qt-5/qabstractbutton.html#iconSize-prop) which takes a QSize instance to describe the desired dimensions of the button's icon.

However, as the docs state: `The default size is defined by the GUI style. This is a maximum size for the icons. Smaller icons will not be scaled up."

So it looks like whatever "the GUI style" is, dictates the size of the button icon. I'm assuming this is the CSS associated with the button. My guess (and it's just that) is Qt won't allow the icon to grow bigger than some (unknown) proportion of the available widget dimension.

[zenmonkeykstop]

WONTFIX in this iteration, icons are displaying as expected. Will revisit as part of future UX work.