Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic display layer #15

Closed
eloquence opened this issue Sep 11, 2018 · 8 comments
Closed

Add basic display layer #15

eloquence opened this issue Sep 11, 2018 · 8 comments
Assignees
Milestone

Comments

@eloquence
Copy link
Member

eloquence commented Sep 11, 2018

Once we have the ability to authenticate (#14) and synchronize data (#5), we should display the available data to the user. For now we can use the first prototype as a guidepost for the client design, but we will iterate on the design as we go, so we can use placeholder colors, icons, etc. for now. Regardless of the final design, we will need a source list view and a per-source detail view.

The data we want to display as part of the list view in the UI is:

  • a list of sources the client knows about
  • when a source was most recently updated (could represent a source or journalist interaction!)
  • whether a source has been starred
  • when the client was last synchronized
  • if I am logged in, what my user name is.

Once we can decrypt messages, we want to also display

  • an excerpt from the most recent interaction with a source in the list view
  • the messages, submissions (just filename / placeholder icon) and replies for that source in the per-source detail view.

NOTE: It may not be possible to display some legacy replies; see #4.

The scope of this task is just the display of information in the list and detail view, not the interactions, which will be tracked separately.

For the first iteration of the display layer, we should not concern ourselves with read/unread status, or the number of new or total messages/submissions for a given source.

@ntoll
Copy link
Contributor

ntoll commented Sep 18, 2018

OK... from an implementation point of view, it'll be easier to implement this before / in parallel with #14 since there's quite a bit of mutual dependency between them in terms of PyQt code.

@ninavizz
Copy link
Member

ninavizz commented Sep 19, 2018

Yet to create an Issue to Gherkin the functionality of allthese things, but tentatively:
• Starring: unstar/star interaction only in the "Message" view, not in the list itself
• Source detail pane, including the interactive header-portion, to deliver this week—stay tuned!
• Want to display Journalist username and picture, and for the picture to accompany journalist name into Source interface—but I suspect that's it's own Beta feature, and a separate feature request for the Source interface?

@eloquence
Copy link
Member Author

Want to display Journalist username and picture, and for the picture to accompany journalist name into Source interface—but I suspect that's it's own Beta feature, and a separate feature request for the Source interface?

Yes, that's probably a post-alpha feature.

@eloquence
Copy link
Member Author

For the 9/24 sprint, we've committed to integration against the development environment, i.e., it should be possible to to

  • launch the client
  • optionally log in (Implement optional login #14)
  • display all data in the dev environment as enumerated in the issue (i.e. messages only, not submitted documents).

@ntoll
Copy link
Contributor

ntoll commented Sep 25, 2018

Hi... some visible signs of progress attached to this comment:

images
styled_login

@ninavizz
Copy link
Member

Not sure if this is the best place on GH for this, but here is ye dummy content!
https://docs.google.com/document/d/16ppERLy-jDlREtwKEmrAT5HCdC3ogcyN_OPsf5HUTQg/edit?usp=sharing

@ntoll
Copy link
Contributor

ntoll commented Oct 11, 2018

Ack on dummy content.

Most of the features of this have landed via merging #29.

@redshiftzero
Copy link
Contributor

fair, closing since the remainder of this functionality is tracked in #32

legoktm pushed a commit that referenced this issue Dec 11, 2023
To be used like below.

pip3 install -r requirements.txt
           --index-url https://dev-bin.ops.securedrop.org/simple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants