Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python easy dependency updates #1468

Closed
18 of 19 tasks
SaptakS opened this issue Aug 12, 2022 · 2 comments · Fixed by #1585
Closed
18 of 19 tasks

Python easy dependency updates #1468

SaptakS opened this issue Aug 12, 2022 · 2 comments · Fixed by #1585
Assignees

Comments

@SaptakS
Copy link
Contributor

SaptakS commented Aug 12, 2022

Update the following packages:

  • bleach | 4.1.0 | 5.0.1 |
  • django-anymail | 8.4 | 8.6 |  
  • django-modelcluster | 5.2 | 6.0 |
  • django-storages | 1.12.3 | 1.13.1 |  
  • django-webpack-loader | 1.4.1 | 1.6.0 |  
  • drf-spectacular | 0.22.1 | 0.23.1 |  
  • drf-spectacular-sidecar | 2022.6.1 | 2022.8.1 |  
  • wagtail-factories | 2.0.1 | 3.1.0 |  
  • docutils | 0.18.1 | 0.19 |  
  • marshmallow | 3.15.0 | 3.17.0 |  
  • psycopg2 | 2.8.6 | 2.9.3 |  
  • pygments | 2.11.2 | 2.12.0 |  
  • wagtailmedia | 0.8.0 | 0.10.1 |  
  • wagtail-inventory | 1.4.1 | 1.5 |  
  • whitenoise | 5.3.0 | 6.2.0 |  
  • unittest-xml-reporting | 3.0.4 | 3.2.0

Remove:

  • Jinja2
  • pyparsing

Also:

  • Unpin structlog and update
@chigby chigby self-assigned this Mar 8, 2023
@chigby
Copy link
Contributor

chigby commented Mar 9, 2023

It actually might not be possible to remove Jinja2. Witness this blast from the past:

#556

Summary: Jinja2 is required by typogrify, a package we are still using in a couple places to convert plain text to HTML.

  1. In the footer:

    {{ footer.body|richtext|typogrify }}

  2. In category page bodies

    {% filter typogrify %}{% render_as_template page.description %}{% endfilter %}

@harrislapiroff
Copy link
Contributor

WOW. I'm actually confused about the places we've chosen to use typogrify and why we saw it as necessary there and not in other places...

But probably best not to rabbit hole on this for the sake of dependency upgrades—leave it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants