Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar wraps incorrectly when using the leaderboard page #125

Closed
raisedadead opened this issue Apr 19, 2024 · 8 comments · Fixed by #141
Closed

Navbar wraps incorrectly when using the leaderboard page #125

raisedadead opened this issue Apr 19, 2024 · 8 comments · Fixed by #141
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@raisedadead
Copy link
Member

On leaderboard page:

image

Everywhere else:

image

This issue could be in the https://github.com/freeCodeCamp/forum-users-nav component, which we had forked for some reason.

@raisedadead raisedadead added help wanted Extra attention is needed bug Something isn't working labels Apr 19, 2024
@a2937
Copy link
Member

a2937 commented May 8, 2024

Should we resync the forum users nav? Also I think the fork had to do with the FreeCodeCamp specific urls.

@raisedadead
Copy link
Member Author

So we have switched to using the official plugin now. The issue still remains. For the URLs we have added permalinks.

@a2937
Copy link
Member

a2937 commented Oct 26, 2024

Now that I actually have a Meta Discourse account, I don't see the navbar on what I believe to be the Leaderboard.

@a2937
Copy link
Member

a2937 commented Oct 28, 2024

I know what class is missing on the forums. I don't know how to edit it though. There's supposed to be this element with a class of navigation-container that keeps everything on a single line. It needs to contain the category-breadcrumb and nav nav-pills and navigation-controls element though.

@raisedadead
Copy link
Member Author

Thanks for investigating, I am hopping @ahmaxed or @huyenltnguyen can help you more.

@a2937
Copy link
Member

a2937 commented Oct 29, 2024

I think I began the process of fixing it already.

https://github.com/discourse/discourse-users-nav/pull/20/files

@raisedadead
Copy link
Member Author

Thanks - you should potentially mention this thread there for context to the maintainers of that project.

@ahmaxed
Copy link
Member

ahmaxed commented Nov 1, 2024

The proposed solution will resolve the issue. I would need access to that repo to approve, and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants