Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trace Propagation to Kafka Events #171

Open
pbrisbin opened this issue Jun 6, 2024 · 0 comments
Open

Add Trace Propagation to Kafka Events #171

pbrisbin opened this issue Jun 6, 2024 · 0 comments

Comments

@pbrisbin
Copy link
Member

pbrisbin commented Jun 6, 2024

This library supports "automatic" trace-propagation via inject/extract/process functions that operate on any HasHeaders a, for which we have instances on Request (for HTTP) and Job (for Faktory).

We should do the same in our Kafka libraries.

My current design would be to make an Envelope around Value (or any a with JSON instances), and put the headers in that envelope. Then you can wrap on produce and unwrap on consume. The only nuance would be to make sure in-flight events that lack an envelope function fine (just without trace context).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant