Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Create UNSET enum value for the ControlPanelColor enum #25

Open
AndrewLester opened this issue Dec 4, 2020 · 0 comments · May be fixed by #29
Open

Create UNSET enum value for the ControlPanelColor enum #25

AndrewLester opened this issue Dec 4, 2020 · 0 comments · May be fixed by #29
Assignees
@BobbyMi11er
Labels
learning goal Something to learn about and memorize

Comments

@AndrewLester
Copy link
Member

AndrewLester commented Dec 4, 2020 •
edited
Loading

Creating an enum value named UNSET in the ControlPanelColor enum would more elegantly handle the state of the match when there has not yet been a color selected by the FMS.

"Your code would be more readable if this was initialized to an enum specifically for 'unset'. I was looking for a constructor but didn't see one, and then saw that there is a null check later on."

Originally posted by @ArchdukeTim in #21 (comment)
@AndrewLester AndrewLester added the learning goal Something to learn about and memorize label Dec 4, 2020
@BobbyMi11er BobbyMi11er linked a pull request Dec 15, 2020 that will close this issue
Open
@AndrewLester AndrewLester mentioned this issue Dec 16, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BobbyMi11er BobbyMi11er

Labels
learning goal Something to learn about and memorize
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create UNSET enum BobbyMi11er/2020-offseason
2 participants
@AndrewLester @BobbyMi11er